Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-14948: implement alertmanager endpoint to receive and update db with events (no subscriber notification) #355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CNF-14948: implement alertmanager endpoint to receive and update db with events (no subscriber notification) #355

wants to merge 1 commit into from

Conversation

pixelsoccupied
Copy link
Collaborator

@pixelsoccupied pixelsoccupied commented Nov 27, 2024 •
edited
Loading

when a list of alerts come in

  • check if event table and the current payload match. If missing set them to resolved
  • collect alarm definitions potentially inject them into alarm event record (e.g alarm def id)
  • Insert and potentially update events tables
  • Move anything thats's resolved into archive

Note: Between the last and second last steps we will notify subscriber

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pixelsoccupied. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pixelsoccupied
Copy link
Collaborator Author

/cc @alegacy
/cc @mlguerrero12

@pixelsoccupied pixelsoccupied force-pushed the am-nofitication branch 2 times, most recently from 05e12b2 to b2b938c Compare November 27, 2024 20:21
@pixelsoccupied
Copy link
Collaborator Author

/hold
making some updates

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
@pixelsoccupied pixelsoccupied changed the title implement alartmanager endpoint receive and update db (no subscriber notification) CNF-14948: implement alartmanager endpoint receive and update db (no subscriber notification) Nov 28, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 28, 2024 •
edited by openshift-ci bot
Loading

@pixelsoccupied: This pull request references CNF-14948 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

when a list of alerts come in

  • check if event table and the current payload match. If missing set them to resolved
  • collect alarm definitions potentially inject them into alarm event record (e.g alarm def id)
  • Insert and potentially update events tables
  • Move anything thats's resolved into archive

Note: Between the last and second last steps we will notify subscriber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pixelsoccupied pixelsoccupied force-pushed the am-nofitication branch 2 times, most recently from 45596e5 to 801f677 Compare November 28, 2024 20:04
@pixelsoccupied
Copy link
Collaborator Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2024
@pixelsoccupied pixelsoccupied changed the title CNF-14948: implement alartmanager endpoint receive and update db (no subscriber notification) CNF-14948: implement alertmanager endpoint to receive and update db with events (no subscriber notification) Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartwensley bartwensley Awaiting requested review from bartwensley

@browsell browsell Awaiting requested review from browsell

@mlguerrero12 mlguerrero12 Awaiting requested review from mlguerrero12

@alegacy alegacy Awaiting requested review from alegacy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixelsoccupied @openshift-ci-robot @alegacy