Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiclusterhub pkg: added package and unit tests #451

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

multiclusterhub pkg: added package and unit tests #451

wants to merge 4 commits into from

Conversation

ElaiShalevRH
Copy link
Collaborator

@ElaiShalevRH ElaiShalevRH commented Jun 2, 2024 •
edited
Loading

Created multiclusterhub.go and multiclusterhub_test.go. Made changes to the clients.go to accept the new import. The rest of the the changes were induced by running go mod / vendor as advised.

@ElaiShalevRH
Copy link
Collaborator Author

@achuzhoy @trewest

@trewest
Copy link
Collaborator

trewest commented Jun 3, 2024

@ElaiShalevRH This PR is bumping the k8s modules to v29 and we are not ready to make this move yet. I would recommend seeing if there is an older commit that you can pull from mch operator until we do the bump in our project. Try the release-2.10 branch

@ElaiShalevRH
Copy link
Collaborator Author

Hey @trewest, changed operator to an older version, changes now seem minimal. Also I've addressed the comments.

trewest
trewest requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@trewest
Copy link
Collaborator

trewest commented Jun 5, 2024

@ElaiShalevRH Added a few comments. Also, please add a Create method

@ElaiShalevRH ElaiShalevRH requested a review from trewest June 6, 2024 11:52
@trewest
Copy link
Collaborator

trewest commented Jun 14, 2024

Spoke to Elai, will most likely need to implement this ourselves as the hive version conflict with other modules in the project

@trewest trewest marked this pull request as draft June 17, 2024 18:53
@trewest
Copy link
Collaborator

trewest commented Jun 17, 2024

Converted to Draft. Seems like there are some conflicts between this pkg and the assisted pkg. We need to implement these APIs ourselves to address them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovn kononovn Awaiting requested review from kononovn kononovn is a code owner

@achuzhoy achuzhoy Awaiting requested review from achuzhoy achuzhoy is a code owner

@cdvultur cdvultur Awaiting requested review from cdvultur cdvultur is a code owner

@trewest trewest Awaiting requested review from trewest trewest is a code owner

@klaskosk klaskosk Awaiting requested review from klaskosk klaskosk will be requested when the pull request is marked ready for review klaskosk is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElaiShalevRH @trewest