Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-15582: ztp: reference: Add description text to metadata.yaml #2119

Merged
merged 1 commit into from
Nov 27, 2024
Merged

CNF-15582: ztp: reference: Add description text to metadata.yaml #2119

merged 1 commit into from
Nov 27, 2024

Conversation

lack
Copy link
Member

@lack lack commented Nov 25, 2024

Signed-off-by: Jim Ramsay [email protected]

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 25, 2024
@openshift-ci-robot
Copy link
Collaborator

@lack: This pull request references CNF-15582 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Signed-off-by: Jim Ramsay [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@lack
Copy link
Member Author

lack commented Nov 25, 2024

/retest

@lack lack force-pushed the reference-descriptions-4.18 branch from 490ab5c to 095866b Compare November 25, 2024 20:25
@nocturnalastro
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 76cc565 into openshift-kni:master Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiller0 imiller0 imiller0 left review comments

@natifridman natifridman Awaiting requested review from natifridman

@nocturnalastro nocturnalastro Awaiting requested review from nocturnalastro

@ijolliffe ijolliffe Awaiting requested review from ijolliffe

@josephdrichard josephdrichard Awaiting requested review from josephdrichard

Assignees

@nocturnalastro nocturnalastro

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ztp/reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lack @openshift-ci-robot @nocturnalastro @imiller0