Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with kernel stop ship tag better pre-GA #1184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Dec 5, 2024

Example config to go with this: openshift-eng/ocp-build-data#5795

`IMPERMISSABLE` assembly issues are.. not permissable. This change makes
the presence of the stop_ship_tag a regular assembly issue, which can be
configured to be permissable for the stream assembly. This could be the
case for most of the pre-GA life time of a y-stream release.
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from joepvd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joepvd
Copy link
Contributor Author

joepvd commented Dec 5, 2024

/hold
timing needs care

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@joepvd
Copy link
Contributor Author

joepvd commented Dec 6, 2024

/test security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant