Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow go previous is none #1182

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

Ximinhan
Copy link
Contributor

@Ximinhan Ximinhan commented Dec 5, 2024

GO_PREVIOUS will be removed so only have latest

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ximinhan. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joepvd
Copy link
Contributor

joepvd commented Dec 5, 2024

We may need this in the future. Possibly better to query if this var is set, and act if so?

@Ximinhan Ximinhan changed the title remove update previous golang allow go previous is none Dec 5, 2024
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@Ximinhan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a7c5174 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thegreyd
Copy link
Contributor

thegreyd commented Dec 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@Ximinhan Ximinhan merged commit 64acbe7 into openshift-eng:main Dec 6, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants