Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ART-3797: add detail to build-sync fail notification in case of non-v… #1165

Merged
merged 1 commit into from
Dec 2, 2024
Merged

ART-3797: add detail to build-sync fail notification in case of non-v… #1165

merged 1 commit into from
Dec 2, 2024
+33 −2

Conversation

mbiarnes
Copy link
Contributor

@mbiarnes mbiarnes commented Dec 2, 2024

…iable stream

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@mbiarnes mbiarnes requested a review from thegreyd December 2, 2024 10:34
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2024 •
edited by openshift-ci bot
Loading

@mbiarnes: This pull request references ART-3797 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

…iable stream

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mbiarnes mbiarnes force-pushed the ART-3797-add-detail-to-build-sync branch from 90601e6 to e47c993 Compare December 2, 2024 11:32
@mbiarnes
Copy link
Contributor Author

mbiarnes commented Dec 2, 2024

tested here: https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fbuild-sync/11989/
image

joepvd
joepvd reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

pyartcd/pyartcd/pipelines/build_sync.py Outdated Show resolved Hide resolved
pyartcd/pyartcd/pipelines/build_sync.py Outdated Show resolved Hide resolved
pyartcd/pyartcd/pipelines/build_sync.py Outdated Show resolved Hide resolved
@mbiarnes mbiarnes force-pushed the ART-3797-add-detail-to-build-sync branch from e47c993 to beab082 Compare December 2, 2024 12:29
@mbiarnes mbiarnes requested a review from joepvd December 2, 2024 13:34
@mbiarnes
ART-3797: add detail to build-sync fail notification in case of non-v…
a25a7ca 
…iable stream

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@mbiarnes mbiarnes force-pushed the ART-3797-add-detail-to-build-sync branch from beab082 to a25a7ca Compare December 2, 2024 14:10
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

@mbiarnes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a25a7ca link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

joepvd
joepvd approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2edf740 into openshift-eng:main Dec 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepvd joepvd joepvd approved these changes

@thegreyd thegreyd Awaiting requested review from thegreyd

Assignees

@joepvd joepvd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbiarnes @openshift-ci-robot @joepvd