fixed art-bot query using catalogs

[mbiarnes]

No description provided.

[mbiarnes]

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mbiarnes]

@ashwindasr now it is working also if we have multiple CDNs or deliveries. Please test it.

[locriandev]

What exception do you expect here? I think we can be more specific and restrict the except block to the expected exception only

[mbiarnes]

@ashwindasr
there are still two things I don't like:

1. when we have i.e. the component_name: ose-cluster-policy-controller-container
   there does not exist a distgit for this repo, but for cluster-policy-controller.
   When it is easy to strip -container it is not clear how to look if ose is needed or not.

2. When accessing an URL like https://art-dash-server-art-dashboard-server.apps.artc2023.pc3z.p1.openshiftapps.com/api/v1/pipeline-image?starting_from=distgit&name=golang-github-prometheus-alertmanager&version=4.16 it takes a lot of time (also when you browse to this URL).
   So the command for art -bot: What catalogs are associated with takes very long! I don't think we can accelerate this.

[ashwindasr]

@mbiarnes

1. We store the brew package name in the image metadata (ocp-build-data config file) itself, so doozer runtime will have the mapping (since the distgit key is the file name)
2. Yes right now its not optimized, but it has the potential to be cached on the server side, if you are looking to optimize it

[mbiarnes]

@ashwindasr
art-bot: what catalog are associated with <release> works.
Before it could fetch from the json file ['config']['config']['label'] the url, but this doesn't work any more.
The resulting catalog url has to be constructed by accessing urls like:
https://art-dash-server-art-dashboard-server.apps.artc2023.pc3z.p1.openshiftapps.com/api/v1/pipeline-image?starting_from=distgit&name=ose-alibaba-cloud-controller-manager&version=4.16
and retrieving from the json answer
delivery_repo_id and delivery_repo_name
The access to https://art-dash-server-art-dashboard-server.apps.artc2023.pc3z.p1.openshiftapps.com/api/v1/pipeline-image?starting_from=distgit&name=>calatog_name>&version=<MAJ.MIN) takes a long amount of time

[openshift-ci]

@mbiarnes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	bbb485e	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mbiarnes]

/unhold