-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version of jszip typings breaks build #13
Comments
Possible fix is to put |
Posted question in Gitter channel https://gitter.im/typings/typings |
We almost certainly need to fix this ourselves by contributing some non-global typings to the |
Need to port |
Published typings for jszip to https://github.com/sebastianhaas/typed-jszip Once it has been accepted, change reference in our |
@acondolu provided a temporary fix for this in dc4b44a by using https://github.com/sebastianhaas/typed-jszip directly. |
Closed for now, #22 still pending. |
https://github.com/DefinitelyTyped/DefinitelyTyped/commits/master/jszip/jszip.d.ts
especially
DefinitelyTyped/DefinitelyTyped@86ce932
They introduced new methods with
Promise
as argument, which is relying on a globalPromise
which we don't have. Can we use it without typings? Can we write our own typings? Have to fix this asap.The text was updated successfully, but these errors were encountered: