Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of jszip typings breaks build #13

Closed
sebastianhaas opened this issue Jul 11, 2016 · 7 comments
Closed

New version of jszip typings breaks build #13

sebastianhaas opened this issue Jul 11, 2016 · 7 comments

Comments

@sebastianhaas
Copy link
Member

https://github.com/DefinitelyTyped/DefinitelyTyped/commits/master/jszip/jszip.d.ts
especially
DefinitelyTyped/DefinitelyTyped@86ce932

They introduced new methods with Promise as argument, which is relying on a global Promise which we don't have. Can we use it without typings? Can we write our own typings? Have to fix this asap.

@sebastianhaas
Copy link
Member Author

Possible fix is to put declare type Promise<T> = any; on top of the index.d.ts file for jszip.

@sebastianhaas sebastianhaas self-assigned this Jul 11, 2016
@sebastianhaas
Copy link
Member Author

Posted question in Gitter channel https://gitter.im/typings/typings

@sebastianhaas
Copy link
Member Author

We almost certainly need to fix this ourselves by contributing some non-global typings to the typingsregistry

@sebastianhaas
Copy link
Member Author

Need to port jziptypings over to the registry.

@sebastianhaas
Copy link
Member Author

Published typings for jszip to https://github.com/sebastianhaas/typed-jszip
PR for registry pending. typings/registry#620

Once it has been accepted, change reference in our typings.json.

@sebastianhaas
Copy link
Member Author

@acondolu provided a temporary fix for this in dc4b44a by using https://github.com/sebastianhaas/typed-jszip directly.

@sebastianhaas
Copy link
Member Author

Closed for now, #22 still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants