Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Jackson-core as a dependency #133

Open
1 of 3 tasks
noCharger opened this issue Apr 28, 2023 · 2 comments
Open
1 of 3 tasks

[Build] Jackson-core as a dependency #133

noCharger opened this issue Apr 28, 2023 · 2 comments
Assignees

Comments

@noCharger
Copy link
Collaborator

noCharger commented Apr 28, 2023

Context

#132

Some GitHub action backend code using jackson-core 2.5.0 is failing builds because it includes an MRJAR with JDK 19 code. See, for example, this failed action.

Action items

  • For the short term, upgrade to jackson-core 2.5.0 in main branch to resolve the build failure. Also upgrade gradle Update Gradle Wrapper to 7.6.1 #132 - Resolved here Fix build #134
  • For the long term, we must devise a sustainable decision on Jackson-core as a dependency ref to Dan's suggestions here. Can we remove all jackson- packages? if not. we need test on build and integration. [Non urgent]
  • Check if the current dependabot is working well, or examine alternatives.

Some observations:

  1. OpenSearch main branch is using jackson-core 2.5.0 https://github.com/opensearch-project/OpenSearch/tree/main/client/sniffer/licenses
  2. Security plugin removed jackson-databind and jackson-annotations Remove jackson-databind and jackson-annotations dependency now coming from core security#2325
  3. Observability plugin removed jackson depenencies and then added them back Revert "Removing explicit jackson dependencies (#1374)" observability#1379
@sejli
Copy link
Member

sejli commented May 2, 2023

Since we currently have build failures, we are opting to upgrade jackson-core to 2.5.0 for now, as implemented in #134. Alternatives are continued to be looked at.

@noCharger noCharger mentioned this issue May 2, 2023
@msfroh msfroh moved this from 🏗 In progress to Now(This Quarter) in Search Project Board May 12, 2023
@macohen
Copy link
Collaborator

macohen commented Jun 13, 2023

What's the latest on this? Should this be closed and a new issue created for long term?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Now(This Quarter)
Development

No branches or pull requests

3 participants