Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RCA will not fail the build if the version doesn't match #191

Open
zelinh opened this issue Jun 14, 2022 · 2 comments
Open

[BUG] RCA will not fail the build if the version doesn't match #191

zelinh opened this issue Jun 14, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zelinh
Copy link
Member

zelinh commented Jun 14, 2022

What is the bug?
A clear and concise description of the bug.
When we clone the repo here in build.gradle,
https://github.com/opensearch-project/performance-analyzer/blob/e5cfc3d40d8015532bb7be5cf1c7b14411fb22e4/build.gradle#L375-L389
even the build version is not incremented and different from the PA, the build will still succeed although it failed silently.

What is the expected behavior?
We should have a mechanism to check if the current version matches with the opensearch_build version, and fail the build immediately if it mismatches the version due to several reasons such as the plugin version not being incremented.

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

@sgup432
Copy link
Contributor

sgup432 commented Jun 15, 2022

Had a discussion with Zelin.
This is not a RCA issue per se. But related to PA plugin package.
Background:
Currently PA has a dependency on RCA and pull the package here in build.gradle.

As of now, when we upgrade OS build version in PA and RCA, we make changes in above line to point PA to correct RCA branch.

Issue/Enhancement:
Right now, when we build PA package, there is no check to verify whether PA (for eg 2.0 branch) is pointing to correct RCA branch/version. We can consider to add these checks.

@kkhatua kkhatua added good first issue Good for newcomers and removed untriaged labels Oct 25, 2022
@praveensameneni
Copy link
Member

@Tjofil , can you please take a look into the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants