-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Optionally disable default certifi certificates #877
Comments
Maybe we could add Either way appreciate a PR! |
I think I can make some time this week |
Yes, your option is probably better, as it is more explicit, but it deviates from the pattern of automatically determining default values used for |
Thanks @nokados. My biggest concern is backwards compatibility, we cannot change the way existing parameters and their values work in the current interface without a major version bump, and a lesser concern future adaptability so we can keep changing it. We can always add of course. Give all these options a try and keep that in mind? |
I've encountered problems: with tests (#879) and with requests support, so the PR will drag on for a while. Some new details about the implementation:
|
Is your feature request related to a problem?
I dislike certifi because it makes managing self-signed certificates difficult. I would prefer to use the system certificate store instead.
What solution would you like?
I believe the most straightforward solution would be to use ca_certs=None if it is explicitly set. Here's what I mean: change this
to this
What alternatives have you considered?
I can't think of any other viable solutions.
The text was updated successfully, but these errors were encountered: