Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Replace lint_per_folder function in noxfile.py with .pylint files #645

Closed
macohen opened this issue Jan 11, 2024 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@macohen
Copy link
Contributor

macohen commented Jan 11, 2024

It may be more standard to use a .pylint file to specify pylint overrides. Advantages could be fewer runs of pylint, more standard. Disadvantages could be that all of those exceptions are peppered throughout the code.

Unless it's trivial this doesn't need to be part of this PR, but maybe there's a more generic solution where a .pylint file is placed into each folder with the configuration for that folder? This code could iterate over the folders and run it with the contents of that config file.

Originally posted by @dblock in #643 (comment)

@github-actions github-actions bot added the untriaged Need triage label Jan 11, 2024
@saimedhi saimedhi removed the untriaged Need triage label Jan 16, 2024
@dblock dblock added the enhancement New feature or request label Jan 17, 2024
@macohen macohen self-assigned this Jan 19, 2024
@macohen
Copy link
Contributor Author

macohen commented Jan 19, 2024

taking a look at moving my fun and maybe too clever code to config...

@macohen
Copy link
Contributor Author

macohen commented Jan 21, 2024

pylintrc files are in use.

@macohen macohen closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants