[FEATURE] Re-create aiohttp.ClientSession after using close() on AsyncOpensearch

[odelmarcelle]

Is your feature request related to a problem?

I find it pretty annoying to handle the close() method of AsyncOpensearch. Basically, once closed, the client becomes unusable because every attempt to connect to the Opensearch cluster will yield the error opensearchpy.exceptions.ConnectionError: ConnectionError(Session is closed) caused by: RuntimeError(Session is closed).

What solution would you like?

This happens because close() effectively closes the aiohttp.ClientSession without removing the attribute from AsyncHttpSession. A simple solution would be to write self.session = None right after

opensearch-py/opensearchpy/connection/http_async.py

Line 279 in e323ab2

await self.session.close()

.

What alternatives have you considered?

Re-creating the AsyncOpensearch instance, which bring unecessary overhead?

Do you have any additional context?

How to create a RuntimeError:

import asyncio
from opensearchpy import AsyncOpenSearch
loop = asyncio.get_event_loop()
opensearch = AsyncOpenSearch(...)
async def get_health():
    print(await opensearch.cluster.health())

loop.run_until_complete(get_health())         # Ok
loop.run_until_complete(opensearch.close())   # Closing
loop.run_until_complete(get_health())         # RuntimeError

[dblock]

This is a good catch, definitely a problem. There should be a way to use with for any connection/instance, too. Please contribute!