Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add Tests for Notifications Plugin #636

Closed
spapadop opened this issue Dec 20, 2023 · 5 comments
Closed

[FEATURE] Add Tests for Notifications Plugin #636

spapadop opened this issue Dec 20, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@spapadop
Copy link

Is your feature request related to a problem?

The plugins.alerting.AlertingClient.create_destination API does not work with latest OpenSearch clusters, as destinations have been deprecated in favor of Notification channels. As a result, using that API gives:

opensearchpy.exceptions.TransportError: TransportError(405, 'Incorrect HTTP method for uri [/_plugins/_alerting/destinations] and method [POST], allowed: [GET]', 'Incorrect HTTP method for uri [/_plugins/_alerting/destinations] and method [POST], allowed: [GET]')

What solution would you like?

Add support for Notification APIs, I guess through a different plugin.

What alternatives have you considered?

One can still use transport.perform_request in order to use Notification channels APIs, but it would be nicer to have it natively supported on the python client.

@spapadop spapadop added enhancement New feature or request untriaged Need triage labels Dec 20, 2023
@dblock
Copy link
Member

dblock commented Dec 20, 2023

Yes, please contribute! I believe you can add the spec to https://github.com/opensearch-project/opensearch-api-specification and the client will auto-generate the methods.

@spapadop
Copy link
Author

Thanks the the prompt reply, I raised opensearch-project/opensearch-api-specification#169 just to get this thing going, I'd appreciate your feedback there so that I can continue the work. Many thanks in advance!

@saimedhi saimedhi removed the untriaged Need triage label Jan 3, 2024
@saimedhi saimedhi changed the title [FEATURE] Add support for Notifications API [FEATURE] Add Tests for Notifications Plugin Apr 19, 2024
@saimedhi
Copy link
Collaborator

Notifications API Added: Updating Issue to Add Tests for the API. Please feel free to contribute.

@saimedhi
Copy link
Collaborator

#668

@saimedhi
Copy link
Collaborator

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants