Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Avoid reflection in pathEncode #1008

Closed
dblock opened this issue May 31, 2024 · 1 comment
Closed

[BUG] Avoid reflection in pathEncode #1008

dblock opened this issue May 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dblock
Copy link
Member

dblock commented May 31, 2024

What is the bug?

In #999 we are using reflection to call pathEncode from the right library. There be dragons.

What is the expected behavior?

Do not use reflection.

Alternatives attempted were to use a common library. A better approach is likely to change the class hierarchy so that the active transport library is doing the encoding.
@dblock dblock added bug Something isn't working untriaged labels May 31, 2024
@dblock dblock mentioned this issue May 31, 2024
Merged
@dblock dblock removed the untriaged label Jun 21, 2024
@Xtansia
Copy link
Collaborator

Xtansia commented Aug 27, 2024

Resolved by #1109

@Xtansia Xtansia closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @Xtansia