Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BuildTarget into BuildTarget and BuildTargetSnapshot #856

Open
dblock opened this issue Nov 2, 2021 · 2 comments · May be fixed by #4245
Open

Refactor BuildTarget into BuildTarget and BuildTargetSnapshot #856

dblock opened this issue Nov 2, 2021 · 2 comments · May be fixed by #4245
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.

Comments

@dblock
Copy link
Member

dblock commented Nov 2, 2021

Is your feature request related to a problem? Please describe

Coming from https://github.com/opensearch-project/opensearch-build/pull/789/files#r741244960, BuildTarget has a lot of if snapshot.

Describe the solution you'd like

Refactor BuildTarget into BuildTarget and BuildTargetSnapshot

Describe alternatives you've considered

No response

Additional context

No response
@dblock dblock added enhancement New Enhancement good first issue Good for newcomers labels Nov 2, 2021
@dblock dblock mentioned this issue Nov 2, 2021
Merged
1 task
@bbarani bbarani added the hacktoberfest Global event that encourages people to contribute to open-source. label Oct 5, 2022
@vchrombie
Copy link

vchrombie commented Sep 28, 2023 •
edited
Loading

Hi @dblock, I am interested to pick up this issue. I have a few assumptions though.

  1. BuildTarget remains as the main class without any snapshot handling.
  2. BuildTargetSnapshot is a subclass of BuildTarget and handles all snapshot-specific behavior.

What do you think about this implementation?

@vchrombie
Copy link

I would like to work on this issue.

@vchrombie vchrombie linked a pull request Nov 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split BuildTarget into BuildTarget and BuildTargetSnapshot classes vchrombie/opensearch-build
3 participants
@dblock @vchrombie @bbarani