Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Benchmark test] Support telemetry parameter #3909

Closed
tlfeng opened this issue Aug 21, 2023 · 1 comment
Closed

[Benchmark test] Support telemetry parameter #3909

tlfeng opened this issue Aug 21, 2023 · 1 comment
Labels
enhancement New Enhancement

Comments

@tlfeng
Copy link
Contributor

tlfeng commented Aug 21, 2023

Is your feature request related to a problem? Please describe

Support telemetry parameters in the benchmark script that used for nightly build.

Some telemetry device support parameters to change its behavior, such as https://github.com/opensearch-project/opensearch-benchmark/blob/ce55073c757303e1f001f14c3c0ef5a1f994fffe/osbenchmark/telemetry.py#L330 (search :param telemetry_params for more usage on that page).

Use case:

  • Collect segment metrics for remote store feature.
    The usage in opensearch-benchmark commands is adding parameters --telemetry="node-stats" --telemetry-params="telemetry.json"
    Then create telemetry.jsonwith content{"node-stats-include-indices":"true","node-stats-include-indices-metrics":"segments"}`. (It's possible to pass parameters in line, except in separate files.)
  • Change metrics collecting interval, by configuring xxx-sample-interval parameters.
  • Filter the index on which the metrics are collected, by configuring xxx-indices pameters. For example, filter out the system indices.

Describe the solution you'd like

Add support for OSB parameter --telemetry-params in this file of benchmark script https://github.com/opensearch-project/opensearch-build/blob/2.9.0/src/test_workflow/benchmark_test/benchmark_args.py

Describe alternatives you've considered

No response

Additional context

No response

@tlfeng tlfeng added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Aug 21, 2023
@rishabh6788
Copy link
Collaborator

--telemetry-params support has been added in #3912.
See successful run here

@rishabh6788 rishabh6788 removed the untriaged Issues that have not yet been triaged label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants