Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Make default target-throughput 0 #530

Closed
OVI3D0 opened this issue Dec 12, 2024 · 4 comments
Closed

[PROPOSAL] Make default target-throughput 0 #530

OVI3D0 opened this issue Dec 12, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@OVI3D0
Copy link
Member

OVI3D0 commented Dec 12, 2024

@IanHoang and I had some discussions today where I asked whether it would be better to maximize throughput by default. This would test the limits of the system by default, and ideally encourage users to set appropriate throughput limits for their use cases, rather than relying on the preset values we currently have.

However, some users may prefer these limits to be on by default as it's easier to compare tests using the same parameters. In this case, we could always introduce a default_throughput file with these throughput values. Running tests with unlimited throughput can also produce more inconsistent results, and users would have to adapt to the new default behavior/difference in their results.

I want to use this issue to gather more opinions on whether we should change the default behavior for target-throughput in OSB.

@OVI3D0 OVI3D0 added enhancement New feature or request untriaged labels Dec 12, 2024
@IanHoang
Copy link
Collaborator

I support the idea of having OSB disable target-throughput by default. Most users seem to be using OSB in benchmarking mode (i.e. target-throughput set to 0 or disabled) and even the public nightly runs do not use target-throughput.

Users mostly use this feature when they need to match a specific throughput level, whether that's to keep some testing variables constant or to simulate throughput levels seen in production clusters. This feels similar to when we moved the changed the default testing pipeline opensearch-project/opensearch-benchmark#326

@Divyaasm
Copy link

@rishabh6788 can you add your thoughts?

@dblock dblock removed the untriaged label Jan 6, 2025
@dblock
Copy link
Member

dblock commented Jan 6, 2025

[Catch All Triage - 1, 2, 3, 4, 5, 6]

@OVI3D0 OVI3D0 closed this as completed Jan 7, 2025
@OVI3D0 OVI3D0 reopened this Jan 7, 2025
@OVI3D0 OVI3D0 removed the untriaged label Jan 7, 2025
@OVI3D0
Copy link
Member Author

OVI3D0 commented Jan 7, 2025

Closing as this issue was discussed offline and users can simply disable target-throughput if they prefer to.

@OVI3D0 OVI3D0 closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants