Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook format check for Slack #787

Closed
Hailong-am opened this issue Oct 12, 2023 · 4 comments · Fixed by #814
Closed

Add webhook format check for Slack #787

Hailong-am opened this issue Oct 12, 2023 · 4 comments · Fixed by #814
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Hailong-am
Copy link
Collaborator

Add Slack webhook URL format check here
https://github.com/opensearch-project/notifications/blob/main/notifications/notifications/src/main/kotlin/org/opensearch/notifications/index/ConfigIndexingActions.kt#L59

it should have same url format check as Microsoft teams

@Hailong-am Hailong-am added the good first issue Good for newcomers label Oct 12, 2023
@Hailong-am Hailong-am added enhancement New feature or request and removed untriaged labels Oct 12, 2023
@bblazek98
Copy link

Hello, could i be assigned to this issue?

@zhichao-aws
Copy link
Member

If we change this validation, we need to modify UT/IT in this repo, as well as in dashboards-notifications. The mock data doesn't have the correct format, and this will fail dashboards-notifications cypress test

@Noir01
Copy link
Contributor

Noir01 commented Nov 8, 2023

Can I be assigned to this, seeing how bblazek98 doesn't seem to be interested?

@SuZhou-Joe
Copy link
Member

Can I be assigned to this, seeing how bblazek98 doesn't seem to be interested?

Sure, assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants