Add RRF tests #992
Add RRF tests #992
Conversation
ryanbogan
force-pushed
the
add_rrf_tests
branch
from
f520028
to
af62e74
Compare
| assertEquals(3, hitsList.size()); | ||
| assertEquals(0.016393442, (Double) hitsList.getFirst().get("_score"), DELTA_FOR_SCORE_ASSERTION); | ||
| assertEquals(0.016129032, (Double) hitsList.get(1).get("_score"), DELTA_FOR_SCORE_ASSERTION); | ||
| assertEquals(0.015873017, (Double) hitsList.getLast().get("_score"), DELTA_FOR_SCORE_ASSERTION); |
There was a problem hiding this comment.
you need to have a resource cleanup block, please check how it's done in other tests (code ref)
| } | ||
|
|
||
| @SneakyThrows | ||
| private void createDefaultRRFSearchPipeline() { |
There was a problem hiding this comment.
check if we can extend the existing method in base class or at least move this method there
There was a problem hiding this comment.
I was trying to do that, but it requires the method in the base class requires a normalization input and the rrf pipeline doesn't have one. Unless there's something I'm missing, we should just move it to the base class.
| } | ||
|
|
||
| @SneakyThrows | ||
| private Map<String, Object> searchRRF(String modelId) { |
There was a problem hiding this comment.
why can't we use existing method from base class, https://github.com/opensearch-project/neural-search/blob/main/src/testFixtures/java/org/opensearch/neuralsearch/BaseNeuralSearchIT.java#L494-L501 or one of it variant. Only customization for RRF is a pipeline name that can be passed as parameter (code ref)
martin-gaievski
force-pushed
the
feature/rrf-score-normalization-v2
branch
from
bcb9df5
to
74c99c5
Compare
…pensearch-project#874) * initial commit of RRF Signed-off-by: Isaac Johnson <[email protected]> Co-authored-by: Varun Jain <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
force-pushed
the
add_rrf_tests
branch
from
57d0822
to
5690405
Compare
|
Commit history met up again. I'll open new PR and link: #997 |
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.