Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java SDK 21.x #1041

Closed
martin-gaievski opened this issue Aug 14, 2023 · 2 comments
Closed

Add support for Java SDK 21.x #1041

martin-gaievski opened this issue Aug 14, 2023 · 2 comments

Comments

@martin-gaievski
Copy link
Member

martin-gaievski commented Aug 14, 2023

What is the bug?
When using JDK 21 (21.0.1-amzn if sdk manager is used to manage JDKs) to build plugin I'm receiving errors saying current gradle version is incompatible with java 21.

Plugin needs to add support for that version in main branch, it's already set as default for distribution builds in corresponding build package in core : https://github.com/opensearch-project/opensearch-build/blob/main/manifests/3.0.0/opensearch-3.0.0.yml#L9

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Install JDK 21. if you're using sdkman
sdk install java 21.0.1-amzn
sdk use java 21.0.1-amzn
  1. Run ./gradlew compileJava
  2. Build fails with error:
Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'opensearch-knn'.
> Could not open proj generic class cache for build file '/k-NN/build.gradle' (/.gradle/caches/7.6.1/scripts/6sy3xxd4if918xuaxzupspk2g).
   > BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 65

What is your host/environment?

  • OS: Linux and Mac
  • main branch
  • Java 21.0.1 (21.0.1-amzn)
@martin-gaievski martin-gaievski added bug Something isn't working untriaged labels Aug 14, 2023
@martin-gaievski martin-gaievski changed the title [BUG] Add support for Java SDK 20.x Add support for Java SDK 20.x Aug 14, 2023
@vamshin vamshin removed the bug Something isn't working label Oct 31, 2023
@martin-gaievski
Copy link
Member Author

This issue isn't relevant anymore, we need to aim for JDK21, it's what core OpenSearch supports now and this will be an LTS release (20 is non-LTS). I'm updating issue description

@martin-gaievski martin-gaievski changed the title Add support for Java SDK 20.x Add support for Java SDK 21.x Oct 31, 2023
@jmazanec15
Copy link
Member

Covered in #1288. Closing

@github-project-automation github-project-automation bot moved this from Backlog to ✅ Done in Vector Search RoadMap Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants