Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Opensearch] Special characters in password silently fails the graceful termination handler #563

Closed
Phenix66 opened this issue Jul 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Phenix66
Copy link

Phenix66 commented Jul 17, 2024

Describe the bug
The auth handling for the opensearch-master-graceful-termination-handler container is not done in a Bash safe manner. Certain characters, such as !, may get interpreted by Bash and cause the entire curl command to silently fail.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy the Opensearch chart with the following non-default values (password value can be anything with ! in it and other characters may break it as well)
masterTerminationFix: true
extraEnvs:
 - name: OPENSEARCH_INITIAL_ADMIN_PASSWORD
   value: ABC123!!def67789
  1. Check the logs of the opensearch-master-graceful-termination-handler container
  2. Note that they are completely empty. If the curl was successful, there should be log messages as to whether or not that node is the master.

Expected behavior
Log messages for the opensearch-master-graceful-termination-handler containers are present

Chart Name
Opensearch

Screenshots
N/A

Host/Environment

  • Helm Version: 3.15.3
  • Kubernetes Version: v1.30.0 (minikube)
@Phenix66 Phenix66 added bug Something isn't working untriaged Issues that have not yet been triaged labels Jul 17, 2024
@Phenix66
Copy link
Author

Nevermind, I overlooked how this executed and was expecting logs when there shouldn't have been. After further testing, no issues.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Engineering Effectiveness Board Jul 17, 2024
@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants