Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] JSDOM is not used as a prod dependency and shouldn't be listed in the package.json as such #318

Open
AMoo-Miki opened this issue Mar 1, 2024 · 0 comments
Open

[BUG] JSDOM is not used as a prod dependency and shouldn't be listed in the package.json as such #318

AMoo-Miki opened this issue Mar 1, 2024 · 0 comments
Assignees
@Swiddis
Labels
bug Something isn't working

Comments

@AMoo-Miki
Copy link
Contributor

dashboards-reporting/package.json

Line 29 in a33c80c

"jsdom": "16.7.0",

jsdom appears to be used only in tests and I didn't find a reference to it in the code. If that is the case, it should be moved to devDependencies.
@AMoo-Miki AMoo-Miki added bug Something isn't working untriaged labels Mar 1, 2024
@Swiddis Swiddis self-assigned this Mar 26, 2024
@Swiddis Swiddis removed the untriaged label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swiddis Swiddis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AMoo-Miki @Swiddis