Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Report generation fails due to Improper URL parsing #281

Closed
AMoo-Miki opened this issue Jan 29, 2024 · 1 comment
Closed

[BUG] Report generation fails due to Improper URL parsing #281

AMoo-Miki opened this issue Jan 29, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers v2.15.0

Comments

@AMoo-Miki
Copy link
Contributor

The logic used in checkURLParams, incorrectly assumes that the URL has a # and causes a JS error when one is not present.

The offending code is

const [hash, query] = location.href.split('#')[1].split('?');
@AMoo-Miki AMoo-Miki added bug Something isn't working untriaged labels Jan 29, 2024
@AMoo-Miki AMoo-Miki changed the title [BUG] Report generation fails due to Improper URL parsinf [BUG] Report generation fails due to Improper URL parsing Jan 29, 2024
@AMoo-Miki
Copy link
Contributor Author

This is breaking Dashboards' Discover in 2.12.

@Swiddis Swiddis removed the untriaged label Mar 27, 2024
@Swiddis Swiddis assigned Swiddis and unassigned Swiddis Mar 27, 2024
@Swiddis Swiddis added the good first issue Good for newcomers label Mar 27, 2024
@AMoo-Miki AMoo-Miki mentioned this issue May 1, 2024
Closed
@rupal-bq rupal-bq mentioned this issue May 7, 2024
Merged
6 tasks
@rupal-bq rupal-bq closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers v2.15.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AMoo-Miki @Swiddis @rupal-bq