Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE Enhancement] Icon Fixed/by Value in document layer #568

Open
canascar opened this issue Dec 20, 2023 · 10 comments
Open

[FEATURE Enhancement] Icon Fixed/by Value in document layer #568

canascar opened this issue Dec 20, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@canascar
Copy link
Member

canascar commented Dec 20, 2023

Is your feature request related to a problem?

As dashboards-maps user, i should be able to style my geospatial field values as different icons based on contents of my field.
RELATED:
#472

Playground
https://playground.opensearch.org/app/maps-dashboards/88a24e6c-0216-4f76-8bc7-c8db6c8705da

What solution would you like?

Add support to use data driven styling in displaying geospatial field as icons in document layer.

Do you have any additional context?

Marker (Default currently available)
Marker - Current
All the same with the addition of a button group to toggle between Marker/Icon UI inputs


Fixed Icon
Icon fixed
User will be able to select from available default map icons or upload their own.

Available map icons as individual or sets
These will be part of the OUI icon pack but used specifically for map visualizations
icons

Icon by value

  • Selecting field
    User can select a field to display data points on the map.
    Icon by value

-Selecting icon set
The dropdown displays existing map icons as sets (Filled/Outline) or customer can choose to custom select icons and areas of representation by defined parameters.

The layer list displays the breakdown of the field value/range represented by the icon

Icon by value-1

Custom icon
Available for fixed and by value icon selection
User will be able to upload their own SVG to add to the dropdown for better representation of their data points.
Add custom icon

@canascar canascar added enhancement New feature or request untriaged labels Dec 20, 2023
@canascar canascar changed the title [FEATURE Enhancement] Icon by value in document layer [FEATURE Enhancement] Icon Fixed/by Value in document layer Dec 20, 2023
@canascar canascar assigned canascar and unassigned canascar Dec 20, 2023
@kamingleung
Copy link

kamingleung commented Dec 20, 2023

@canascar For Icon by value, does this let users display the text values on the map instead of icons? If so, does it make sense to have Text/Value as a 3rd option under Symbol type?

  1. I wonder if the terms Fixed and By Value are clear to users on what functionality they offer.
  2. Is there a need for users to remove custom icons they have uploaded?

@canascar
Copy link
Member Author

Hi @kamingleung

  1. we are using these terms in Cluster layers as well to denote whether the user is selecting data points populated fixed by the entire data set of by value of a selected field within the data.
  2. When the user uploads the icons they will be stored and will be reusable in other map visualizations, listed in the dropdown under Custom icons.

@kamingleung
Copy link

kamingleung commented Dec 21, 2023

  1. Perhaps providing some context upfront to users may be helpful? Either with helper text or help icon popover.
  2. I wonder if there's a way to delete custom icons the users have uploaded?

@canascar
Copy link
Member Author

@kamingleung

  1. Sure, I can work on adding something in.
  2. Icons would populate the dropdown in their own category "Custom icons" and it's the only area where they would be accessible. We can however, discuss if it's necessary for the option to delete (as they will always be able to choose whether or not to use the file) but it would be another flow to consider that may push the release of this enhancement. Perhaps it's a P1 or P2 addition. I can talk to devs about it.

@kamingleung
Copy link

@canascar

  1. Were you able to make changes to provide users some upfront context?
  2. I don’t think it’s a release blocker if users cannot delete custom icons, but it should be a fast follow.

@canascar
Copy link
Member Author

canascar commented Feb 2, 2024

@kamingleung Ah yes.. help info - rethinking this one - do you suggest adding to all fields? I am wondering where perhaps you may envision this- also the questionInCircle - is that a pattern we are adopting more regularly in our field labels?

@kamingleung
Copy link

kamingleung commented Feb 2, 2024

I would suggest only adding help info on the fields that may benefit with additional context. We can leverage the hover questionInCircle pattern – especially on a compressed space like this.

@canascar
Copy link
Member Author

canascar commented Feb 8, 2024

I would suggest only adding help info on the fields that may benefit with additional context. We can leverage the hover questionInCircle pattern – especially on a compressed space like this.

Added help content to enhance in-context documentation @kamingleung please review, thanks!

Screenshot 2024-02-08 at 9 43 40 AM

@kamingleung
Copy link

@canascar Thanks for the updates. Looks good to me!

@dblock dblock removed the untriaged label Jun 17, 2024
@dblock
Copy link
Member

dblock commented Jun 17, 2024

Was this completed? Can this be closed?

Catch All Triage - 1 2 3 4 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants