-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Flat object field should delegate to keyword field for most query types #11635
Labels
Comments
@rawwar are you interested in investigating this? |
3 tasks
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
Oct 14, 2024
github-project-automation
bot
moved this from Later (6 months plus)
to ✅ Done
in Search Project Board
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The flat object field type currently reimplements most of the query-generation methods with code that was copied from KeywordField. Since then, KeywordField had changes to support dynamically switching between indexed fields and doc values to implement these query types, based on which is likely to be more efficient.
Since the flat object field is implemented with a pair of KeywordFields under the hood, we should just ask those fields to create their own darned queries, which will do the correct, optimized thing, and reduce code duplication.
The text was updated successfully, but these errors were encountered: