Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flat object field should delegate to keyword field for most query types #11635

Closed
msfroh opened this issue Dec 18, 2023 · 2 comments · Fixed by #14383
Closed

[BUG] Flat object field should delegate to keyword field for most query types #11635

msfroh opened this issue Dec 18, 2023 · 2 comments · Fixed by #14383
Labels

Comments

@msfroh
Copy link
Collaborator

msfroh commented Dec 18, 2023

Describe the bug
The flat object field type currently reimplements most of the query-generation methods with code that was copied from KeywordField. Since then, KeywordField had changes to support dynamically switching between indexed fields and doc values to implement these query types, based on which is likely to be more efficient.

Since the flat object field is implemented with a pair of KeywordFields under the hood, we should just ask those fields to create their own darned queries, which will do the correct, optimized thing, and reduce code duplication.

@macohen
Copy link
Contributor

macohen commented Dec 20, 2023

@rawwar are you interested in investigating this?

@kkewwei
Copy link
Contributor

kkewwei commented Jun 3, 2024

@macohen @rawwar If i can try it if you haven't do?

@harshavamsi harshavamsi moved this from Now (This Quarter) to In Progress in Performance Roadmap Jun 17, 2024
@getsaurabh02 getsaurabh02 added the v2.16.0 Issues and PRs related to version 2.16.0 label Jun 24, 2024
@mch2 mch2 added v2.17.0 and removed v2.16.0 Issues and PRs related to version 2.16.0 labels Jul 29, 2024
@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Search Project Board Aug 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Oct 14, 2024
@github-project-automation github-project-automation bot moved this from Later (6 months plus) to ✅ Done in Search Project Board Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants