Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only allow certain file types to be written to Level 4 #13

Open
wjchulme opened this issue Jan 25, 2021 · 0 comments
Open

only allow certain file types to be written to Level 4 #13

wjchulme opened this issue Jan 25, 2021 · 0 comments

Comments

@wjchulme
Copy link

As a minimum: txt csv tsv log json svg png jpeg ipynb md html pdf.

My main thinking for this is that R objects often contain the the arguments that were passed to them, such as data frames (and sometimes entire environments). This is Bad because a user might be tempted to release that object out of L4 for local processing, without realising the security implications. For example a ggplot object contains the data used to plot the object, even if the plot is for lower dimension derivations of the data like a density plot or a chart showing pairwise correlations. There are lots of other examples.

Github's 100mb file limit won't catch everything, especially with compression. Asumming a whitelist is probably safer than a blacklist.

Arguably html md and pdf could contain disclosive info that isn't visible when rendered but i think that's a separate issue.

May need a system request additional file types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant