IndexError: string index out of range

[sentry-io]

Sentry Issue: JOB-SERVER-MF

TypeError: 'User' object is not subscriptable
  File "django/template/base.py", line 883, in _resolve_lookup
    current = current[bit]
  File "django/utils/functional.py", line 253, in inner
    return func(_wrapped, *args)

IndexError: string index out of range
(24 additional frame(s) were not displayed)
...
  File "jobserver/models/user.py", line 218, in initials
    return "".join(w[0].upper() for w in self.name.split(" "))
  File "jobserver/models/user.py", line 218, in <genexpr>
    return "".join(w[0].upper() for w in self.name.split(" "))

[Jongmassey]

This appears to be based in the initials generation code which is used in place of GitHub avatars (slack thread ) which fails with @Mary-Anya 's mononymic user account trailing space in username (see below)

[Jongmassey]

>>> failures = []
>>> for u in User.objects.all():
...   try:
...     i = u.initials
...   except:
...     failures.append(u)
... 
>>> failures
[<User: Mary >]

also

select * from jobserver_user u where fullname like '% ' or username like '% '

just returns Mary's user

I think it's because Mary's fullname has a trailing space

[mikerkelly]

If I go to http://localhost:8000/settings/ and enter some trailing spaces in my fullname they seemingly get scrubbed on form save. And the same at http://localhost:8000/staff/users/mikerkelly/.

So probably it is only the social auth initial population we need to worry about.

User.fullname has a comment saying this is initially populated by social auth. Probably we could address the issue by overriding User.save or with a pre_save signal to strip whitespace from that field.