Fix top 5 #209
Closed
Fix top 5 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we'll extract these in a separate study definition because we only need to extract them once if we use "number_of_matches_in_period" for the entire study period
This isn't used anymore as we're defining the code variables using "number_of_matches_in_period"
This extracts variables once. In doing so, name this study definition more generally
As part of this handle 0 total events in top 5
As part of this handle descriptions without match top 5
As part of this order columns in the two versions of top 5 consistently
|
I'm closing this until we have capacity to review. It's tracked in the linked issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #109
On the way it also resolves #149 and partially extends the test coverage for the code relevant to the top 5 tables, which is tracked by #184