Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support to justfile #40

Closed
ccunningham101 opened this issue May 4, 2022 · 1 comment · Fixed by #41
Closed

Add windows support to justfile #40

ccunningham101 opened this issue May 4, 2022 · 1 comment · Fixed by #41

Comments

@ccunningham101
Copy link

ccunningham101 commented May 4, 2022

Current justfile does not work on Windows
This will affect anyone who might want to develop and test reusable actions on Windows
Investigate whether adding windows support as was done in the repo-template will work here

@Jongmassey
Copy link

Justfile as per opensafely-core/repo-template@7ab8eab runs fine in git-bash on windows; but installing the requirements listed in repo-template fails with the following:

Collecting typing-extensions>=3.10.0.0
ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    typing-extensions>=3.10.0.0 from https://files.pythonhosted.org/packages/75/e1/932e06004039dd670c9d5e1df0cd606bf46e29a28e65d5bb28e894ea29c9/typing_extensions-4.2.0-py3-none-any.whl#sha256=6657594ee297170d19f67d55c05852a874e7eb634f4f753dbd667855e07c1708 (from black==22.3.0->-r requirements.dev.txt (line 17))```


In my experience, manually installing the dependent requirement which is un-pinned is a way of working around this; whereas no workarounds for the problems encountered with the old version of the justfile were found

iaindillingham added a commit that referenced this issue May 5, 2022
This copies justfile from opensafely-core/repo-template, remembering to
downgrade Python from 3.10 to 3.8, because opensafely-core/python-docker
supports 3.8.

Closes #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants