Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement knit_print for GeneralModel objects #795

Closed
Puzzled-Face opened this issue Feb 16, 2024 · 2 comments · Fixed by #796
Closed

Implement knit_print for GeneralModel objects #795

Puzzled-Face opened this issue Feb 16, 2024 · 2 comments · Fixed by #796
Assignees
@Puzzled-Face
Labels
enhancement New feature or request

Comments

@Puzzled-Face
Copy link
Collaborator

See #774 for details.
@Puzzled-Face Puzzled-Face added the enhancement New feature or request label Feb 16, 2024
@Puzzled-Face Puzzled-Face self-assigned this Feb 16, 2024
@Puzzled-Face Puzzled-Face mentioned this issue Feb 16, 2024
Open
34 tasks
@Puzzled-Face Puzzled-Face changed the title Implement knit_print for LogisiticLogNormal objects Implement knit_print for LogisticLogNormal objects Feb 16, 2024
@Puzzled-Face Puzzled-Face linked a pull request Feb 23, 2024 that will close this issue
795 implement knit print for Model objects #796
Merged
@Puzzled-Face Puzzled-Face changed the title Implement knit_print for LogisticLogNormal objects Implement knit_print for GeneralModel objects Mar 1, 2024
@Puzzled-Face
Copy link
Collaborator Author

Puzzled-Face commented Mar 1, 2024 •
edited
Loading

Note that final implementation of knit_print for DualEndpoint models depends on the resolution of #799.

@Puzzled-Face
Copy link
Collaborator Author

From the online doc, I couldn't deduce what I needed to implement knit_print methods for the OneParLogNormalPrior OneParExpPrior, DALogisticLogNormal, TITELogisticLogNormal, and FractionalCRM classes. I would appreciate help on these.

I still need to write tests for non-standard cases and for helper functions and methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Puzzled-Face Puzzled-Face

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

795 implement knit print for Model objects openpharma/crmPack
1 participant
@Puzzled-Face