feat: O3-310: Add an application-writable config.json file in frontends/ (attempt #2) #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -41.2 kB (-1%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
|
This actually depends on openmrs/openmrs-module-webservices.rest#595, which is the active version of that PR. |
samuelmale
reviewed
Feb 8, 2024
Comment on lines
+163
to
+166
| useMemo(async () => { | ||
| const dependencies = await initInstalledBackendModules(); | ||
| setBackendDependencies(dependencies); | ||
| }, []); |
There was a problem hiding this comment.
Can we use a useEffect instead?
| @@ -155,3 +156,21 @@ export async function checkModules(): Promise<Array<ResolvedDependenciesModule>> | |||
| export function hasInvalidDependencies(frontendModules: Array<ResolvedDependenciesModule>) { | |||
| return frontendModules.some((m) => m.dependencies.some((n) => n.type !== 'okay')); | |||
| } | |||
|
|
|||
| export function useBackendDependencyCheck(moduleName: string) { | |||
There was a problem hiding this comment.
I would rename the hook to something like: useBackendModuleExists(moduleName: string). What do you think of adding an optional parameter that validates the module versions:
export function useBackendModuleExists(moduleName: string, moduleVersion?: string) {}There was a problem hiding this comment.
Agree with the rename, but don't complicate code for no reason. You can add that parameter when you need it.
There was a problem hiding this comment.
I actually think we are going to need a version check for this to function properly. Regardless of which module the backend code for this goes into, it's only going to be available from the next version on, so it would be nice if isSpaModulePresent was actually based on not just the presence of the module, but the presence of at least a minimal version...
ibacher
force-pushed
the
main
branch
2 times, most recently
from
8f994a6
to
9cee659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #864
This restores @jnsereko 's #629.
Depends on openmrs/openmrs-module-spa#57 .
Sorry about the hasty work. Let's get this stuff in though.