Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email related functions #301

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Fix email related functions #301

merged 9 commits into from
Dec 18, 2023

Conversation

AndrewZuo01
Copy link
Contributor

@AndrewZuo01 AndrewZuo01 commented Dec 14, 2023 •
edited
Loading


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

#305 #319

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@AndrewZuo01 AndrewZuo01 requested review from cubxxw and a team as code owners December 14, 2023 02:23
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 14, 2023
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2023
@AndrewZuo01 AndrewZuo01 changed the title Fix email Fix email related functions Dec 14, 2023
cubxxw
cubxxw previously approved these changes Dec 15, 2023
View reviewed changes
@cubxxw cubxxw enabled auto-merge December 15, 2023 02:18
auto-merge was automatically disabled December 15, 2023 03:01

Head branch was pushed to by a user without write access

FGadvancer
FGadvancer previously approved these changes Dec 18, 2023
View reviewed changes
@kubbot
Copy link
Contributor

kubbot commented Dec 18, 2023 •
edited
Loading

CLA Assistant Lite bot 🤖 All Contributors have signed the chat CLA.
The signed information is recorded 🤖here

@FGadvancer
Copy link
Member

I have read the CLA Document and I hereby sign the CLA

openimbot added a commit to openim-sigs/cla that referenced this pull request Dec 18, 2023
@openimbot
@FGadvancer has signed the CLA in openimsdk/chat#301
35fad26
@cubxxw
Copy link
Contributor

cubxxw commented Dec 18, 2023

recheck

@cubxxw cubxxw enabled auto-merge December 18, 2023 02:08
@cubxxw cubxxw added this pull request to the merge queue Dec 18, 2023
Merged via the queue into openimsdk:main with commit b0db9d1 Dec 18, 2023
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewZuo01 @kubbot @FGadvancer @cubxxw