Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications don't load when many notifications are filtered #3837

Open
mueller-ma opened this issue Dec 1, 2024 · 0 comments
Open

Notifications don't load when many notifications are filtered #3837

mueller-ma opened this issue Dec 1, 2024 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@mueller-ma
Copy link
Member

Actual behaviour

In the notification fragment due to duplicate reference ids there may be less than 20 (current PAGE_SIZE) notifications shown and thus the loading indicator is shown after loading the first 20 notifications. It's bound to the recycler view, which triggers fetching the next 20 notifications. When there are too many notifications filtered in this second request, so the loading indicator doesn't disappear, no more requests are made.

Expected behaviour

Load until the page is visually full.

@mueller-ma mueller-ma added the bug Indicates an unexpected problem or unintended behavior label Dec 1, 2024
mueller-ma added a commit to mueller-ma/openhab.android that referenced this issue Dec 2, 2024
Now notifications can be hidden by other notifications which might require that fetching 20 notifications isn't enough to fill one page. Thus increase the page size to 50.

Also see openhab#3837
mueller-ma added a commit to mueller-ma/openhab.android that referenced this issue Dec 2, 2024
Now notifications can be hidden by other notifications which might require that fetching 20 notifications isn't enough to fill one page. Thus increase the page size to 50.

Also see openhab#3837

Signed-off-by: mueller-ma <[email protected]>
mueller-ma added a commit that referenced this issue Dec 4, 2024
Now notifications can be hidden by other notifications which might require that fetching 20 notifications isn't enough to fill one page. Thus increase the page size to 50.

Also see #3837

Signed-off-by: mueller-ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant