Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all examples updates for other platforms #415

Open
artificiel opened this issue Sep 6, 2023 · 1 comment
Open

update all examples updates for other platforms #415

artificiel opened this issue Sep 6, 2023 · 1 comment
Labels

Comments

@artificiel
Copy link
Contributor

I am giving a stab at streamlining the "install from git" instructions, and for the first time I tried "update multiple".

it's mostly harmless but I found it surprising (and could end up confusing) that all directories including eg android are preprocessed for a Xcode platform.

would a form of filter/map be possible to only process the relevant example for a given platform?

@dimitre
Copy link
Member

dimitre commented Oct 13, 2023

Yes good idea.
PG it is now using fs::recursive_directory_iterator so it is getting everything with a src folder inside.
it is possible to program to ignore "android / ios / tvOS" folders. I prefer not hardcode out this folders.
As an alternative idea: we could have different examples folders for this unique platforms.
Folders like this three have a different nature than the other ones, they are not multiplatform so maybe they could live in other folders in git repository, like:

$ofw/examples_android/all
$ofw/examples_ios/ios
$ofw/examples_ios/tvOS

there is another funny thing that happens:
if you compile one example using make,
make creates an obj folder with a src folder inside
and then you execute PG recursively over examples
it will be creating some projects inside obj folder also.

@dimitre dimitre added the cli label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants