Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Molecule.canonical_order_atoms optionally return a mapping from the old to the new atom order #1123

Open
j-wags opened this issue Nov 6, 2021 · 1 comment

Comments

@j-wags
Copy link
Member

j-wags commented Nov 6, 2021

This would unblock an important feature in fragmenter. Full description at openforcefield/openff-fragmenter#129

I think the best way to do this is to thread a new kwarg through Molecule, RDKitToolkitWrapper, and OpenEyeToolkitWrapper's canonical_order_atoms methods.

@SimonBoothroyd
Copy link
Contributor

+1 to this, and also, ensure that map indices survive the trip through this method. See also here for an example implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants