Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Pydantic v1 and v2 #165

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Test on Pydantic v1 and v2 #165

merged 4 commits into from
Aug 7, 2023

Conversation

mattwthompson
Copy link
Member

Description

This PR updates the codebase to work with both Pydantic v1 and v2 and also tests each case.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #165 (8dbf4fa) into main (5a33549) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending test success! The CI matrix is huge now, can we drop the pydantic v1 tests before merging?

@mattwthompson
Copy link
Member Author

I'd prefer one of the following options:

  1. Drop v1 from the test matrix and make a release based off of this that is explicitly pydantic =2
  2. Keep just one v1 test in the matrix and make a release that stills supports v1 and v2

Does either sound acceptable to you? My preference is to do 2, since BespokeFit and some other downstreams don't yet work on v2, but follow this release up with one that drops v1 once it can

@mattwthompson
Copy link
Member Author

I'm electing to go for option 2 as that allows #164 to slip in to environments that aren't yet updated for Pydantic v2

@mattwthompson mattwthompson merged commit 41534f5 into main Aug 7, 2023
@mattwthompson mattwthompson deleted the pydantic-1-2 branch August 7, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants