Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail OpenEye checks if installed but not licensed #164

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Fail OpenEye checks if installed but not licensed #164

merged 4 commits into from
Aug 4, 2023

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Jul 14, 2023 •
edited
Loading

Description

Resolves #163

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Uses requires_openeye_module to raise MissingOptionalDependencyError when OpenEye is installed but not licensed
  • Catches MissingOptionalDependencyError when above happens

Questions

  • Question1

Status

  • Ready to go

This was referenced Jul 14, 2023
Closed
Closed
@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #164 (d41c6f4) into main (5a33549) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review July 14, 2023 18:00
@mattwthompson mattwthompson requested review from j-wags and jthorton July 14, 2023 18:00
j-wags
j-wags approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mattwthompson

@mattwthompson mattwthompson mentioned this pull request Aug 4, 2023
Merged
@mattwthompson mattwthompson merged commit 390388d into main Aug 4, 2023
@mattwthompson mattwthompson deleted the openeye-license branch August 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

@jthorton jthorton Awaiting requested review from jthorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip OpenEye functions if license not found, even if installed
2 participants
@mattwthompson @j-wags