Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The color contrast between the card and the background is not the same in List views, and sub knowledge panel, as in the product page #5910

Open
teolemon opened this issue Nov 23, 2024 · 1 comment · Fixed by #5920
Open

The color contrast between the card and the background is not the same in List views, and sub knowledge panel, as in the product page #5910

teolemon opened this issue Nov 23, 2024 · 1 comment · Fixed by #5920

Comments

@teolemon
Copy link
Member

What

  • The new product page color contrast between the card and the background is crisp and nice.
  • The color contrast between the card and the background is not the same in List views, and sub knowledge panel, as in the product page
@teolemon teolemon transferred this issue from openfoodfacts/openfoodfacts-server Nov 23, 2024
@g123k g123k self-assigned this Nov 24, 2024
@g123k g123k linked a pull request Nov 24, 2024 that will close this issue
fix: Knowledge Panel page: bg color in light mode + product name #5920
Merged
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 24, 2024
@g123k g123k reopened this Nov 24, 2024
@g123k
Copy link
Collaborator

g123k commented Nov 24, 2024

We still have the issue on search pages

@g123k g123k removed their assignment Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 🤔 To reproduce
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Knowledge Panel page: bg color in light mode + product name g123k/smooth-app
2 participants
@g123k @teolemon