Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide which issues are release blockers for the public beta of Smoothie #437

Closed
Tracked by #500
stephanegigandet opened this issue Jul 21, 2021 · 8 comments
Closed
Tracked by #500

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Jul 21, 2021

Summer is here, everyone could use a fresh smoothie!

Thanks to all your hard work, we have a really cool app with personalization features and lists that I haven't seen anywhere else.

Let's remove the really blocking issues (if any), let's not worry too much about small imperfections, and let's release smoothie!

Would everyone be fine with that?

In the hope that you are, we can use GitHub's project feature to plan, make, and track progress:
https://github.com/openfoodfacts/smooth-app/projects/8

The first step would be to list all the things we really need to fix / to do before we can release a public version.

We can make 2 lists:

1 - Must fix / must do

  • fixes for bugs that make the app crash
  • fixes for features that do not work (e.g. if we can't scan or open products)

2 - Nice to have, but not necessary

We can focus on the first list, and I think we should release as soon as we have done the must do list, and not wait for nice to have features.

We have a rather big list of open issues (currently 18 open) in https://github.com/openfoodfacts/smooth-app/milestone/1 for the "V0.9 - Soft launch" milestone. Some of those are probably things that we could release without.

So I propose to create a new list "V0.9 - Soft launch - Must do" https://github.com/openfoodfacts/smooth-app/milestone/3 where we put as few issues as possible.

Part of

@stephanegigandet
Copy link
Contributor Author

Thanks @monsieurtanuki ! Let's move all the Very important + Important issues to the public beta project.

I'm curious about that one. I agree it's very important that we eventually have it so that we can have play + app store screenshots in 200 languages, but for the beta, we could start with manual screenshots in English (and possibly a couple of other languages).

@monsieurtanuki
Copy link
Contributor

I can help with the 3 "initial languages" (en, de, fr) with the shell script I was talking about.
Semi-automatic then.
And while it's running, I cannot use my computer. Therefore, for a start let's limit it to a small number of languages.

@M123-dev
Copy link
Member

@monsieurtanuki does the script only work for ios or also for Android virtual machines

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Jul 23, 2021

@M123-dev I haven't tried for Android - I will have to for my own app, though.
The only tricky part is to switch languages: how to do that in shell on an Android simulator.

For the record the principles so far are:

  1. write a flutter "test" (do something, take a screenshot, do something else, take another screenshot, ...)
  2. write a shell script that loops for all languages: {switch to a language/country, run the test}
  3. open an iOS simulator (5.5", 6.5" or 12.9")
  4. run the shell script

Specific potential issue for smoothie: the scanner, on a simulator.

[Edit: added]
Code excerpt:

./ios_simulator.sh $SIMULATOR locale fr_FR
./ios_simulator.sh $SIMULATOR shutdown
./ios_simulator.sh $SIMULATOR boot
sleep 120
LANGUAGE=fr flutter drive --target=test_driver/app.dart

@M123-dev
Copy link
Member

@monsieurtanuki
Probably this could to the trick for android

https://stackoverflow.com/a/41654317/13313941

Regarding the scanner, in the android virtual device camera you get thrown into a 3D world where you can walk around and you can even insert custom images on some points, like the wall or on top of the table. But I doubt that this is possible via script.

I only found a workaround where you have to replace some local files.
When we keep one product and do not choose to use local ones this should be fine.
https://stackoverflow.com/a/64922184/13313941

@stephanegigandet
Copy link
Contributor Author

stephanegigandet commented Jul 26, 2021

Adding user management is very important I think:

Is someone interested in working on it?

If there are missing APIs etc. on the server side, I can help on that. But I certainly won't be the fastest to implement the Flutter part in Smoothie.

@teolemon
Copy link
Member

teolemon commented Feb 6, 2022

  • Everything from those lists are implemented, and the beta has been launched.
  • Closing this one

@teolemon teolemon closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants