Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebView new init method #3672

Closed
monsieurtanuki opened this issue Feb 4, 2023 · 0 comments · Fixed by #3688
Closed

Fix WebView new init method #3672

monsieurtanuki opened this issue Feb 4, 2023 · 0 comments · Fixed by #3688
Assignees
@M123-dev
Labels
🐛 bug Something isn't working 👥 User management Account login, signup, signout

Comments

@monsieurtanuki
Copy link
Contributor

What

  • In feat: 3585 - upgrade to flutter 3.7 #3666 many packages were upgraded to their latest versions.
  • Unfortunately, for webview_flutter there were some breaking changes that were not dealt with on our side.
  • The fix should be minor. We may even imagine rolling back to the previous version.
  • The impact is on only one page that is (hopefully) not used very often: the page where the user says the account must be deleted!
  • cf. feat: web account deletion #3416 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M123-dev M123-dev

Labels
🐛 bug Something isn't working 👥 User management Account login, signup, signout
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Webview openfoodfacts/smooth-app
3 participants
@teolemon @monsieurtanuki @M123-dev