-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline Robotoff questions to increase the answer rate #3326
Comments
can I work on it? |
Thats a great idea @teolemon and sure @prathamsoni11 |
|
My 2 cents:
|
Adding the next two cents:
|
Ohh @prathamsoni11 I think we were talking past each other there. I liked the color of the buttons. The background color of the whole card is too bright for the darkmode |
Can you suggest to me which background colour should I replace this? |
Just go with the default background colors for dark mode , i think that would be fine |
Are you referencing this "Theme.of(context).colorScheme.background" for background colour |
Yeah did you tried that!? |
@AshAman999 yes I initialised this as the background colour. |
@prathamsoni11 What i meant was B as same color as A Is it what u did too ? |
@AshAman999 What about that shimmer effect and that finish widget? Screenrecorder-2022-12-09-18-12-37-631.mp4 |
No, A and B are not same I have to look what A is using and I will do same with B 😁 |
@AshAman999 changed card colour as you said |
I guess it looks good as of now, just double check if it looks consistent even on the light theme and do create a PR |
@AshAman999 also have a look to this. |
ok I will drop a screenshot |
Looks great, my only concern is the text size, we could make it smaller and more subtle, it's only a sub feature of the product page |
Unsure @prathamsoni11 @M123-dev ? |
@g123k I think it was either not used or a complete duplicate of |
Ok, so I will re-introduce it, or partially at least. Robotoff.webm |
Nice catch |
What
Mockups
Part of
The text was updated successfully, but these errors were encountered: