Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Robotoff questions to increase the answer rate #3326

Open
Tracked by #4027 ...
teolemon opened this issue Nov 16, 2022 · 29 comments
Open
Tracked by #4027 ...

Inline Robotoff questions to increase the answer rate #3326

teolemon opened this issue Nov 16, 2022 · 29 comments
Assignees
Milestone

Comments

@teolemon
Copy link
Member

What

  • Inline Robotoff questions
  • This will make the thank you screen and potential points less visible
  • This will probably increase the answer rate
  • Each time a question is answered, it disappears, and the next question is shown
  • Eventually, the card disappears, potentially after a thank-you card for a few seconds
  • We could potentially animate openfoodfacts-events points addition with coins that move towards the settings bottombar

Mockups

image

Part of

@prathamsoni11
Copy link
Contributor

can I work on it?

@M123-dev
Copy link
Member

Thats a great idea @teolemon and sure @prathamsoni11

@prathamsoni11
Copy link
Contributor

Something like this a recreated. Do let me know if there are any changes to be made?

@teolemon
Copy link
Member Author

  • Good
  • I think there's probably something that we need to change about colors (going back to Robotoff blue, like on web)
  • You can probably PR now anyway

@monsieurtanuki
Copy link
Contributor

My 2 cents:

  • Robotoff may have a specific image (e.g. "packaging" instead of "front" first)
  • not everybody has a tall smartphone
  • not in all languages will you be lucky enough to cram "skip", "yes" and "no" on the same line

@M123-dev
Copy link
Member

Adding the next two cents:

  • The background color is too bright, something greyish would fit better (in my opinion)
  • We should make this card a bit smaller in heigtht. The buttons are very tall
  • I agree with the 3 buttons, but thats a somethat harder UI question, a cross like we plan to do in Simplify adding photos by removing 2 of the 4 steps #3332 isn't clear to skip. Using icons for "Yes" and "No" and writing out Skip would make the skip button to big in comparison.

@prathamsoni11
Copy link
Contributor

prathamsoni11 commented Nov 23, 2022

Tried changing the button's colour to greyish and reduced the size. Also changed the position on "yes" and "no"

@M123-dev
Copy link
Member

Ohh @prathamsoni11 I think we were talking past each other there. I liked the color of the buttons. The background color of the whole card is too bright for the darkmode

@prathamsoni11
Copy link
Contributor

Ohh @prathamsoni11 I think we were talking past each other there. I liked the colour of the buttons. The background colour of the whole card is too bright for the dark mode

Can you suggest to me which background colour should I replace this?

@AshAman999
Copy link
Member

Just go with the default background colors for dark mode , i think that would be fine

@prathamsoni11
Copy link
Contributor

prathamsoni11 commented Nov 24, 2022

Just go with the default background colors for dark mode , i think that would be fine

Are you referencing this "Theme.of(context).colorScheme.background" for background colour

@AshAman999
Copy link
Member

Yeah did you tried that!?

@prathamsoni11
Copy link
Contributor

@AshAman999 yes I initialised this as the background colour.

@AshAman999
Copy link
Member

AshAman999 commented Nov 30, 2022

@prathamsoni11
Maybe i am not sure about the theme color names

What i meant was

B as same color as A

image

Is it what u did too ?

@teolemon teolemon added this to the 4.2 milestone Dec 1, 2022
@prathamsoni11
Copy link
Contributor

prathamsoni11 commented Dec 9, 2022

@AshAman999 What about that shimmer effect and that finish widget?

Screenrecorder-2022-12-09-18-12-37-631.mp4

@prathamsoni11
Copy link
Contributor

@prathamsoni11 Maybe i am not sure about the theme color names

What i meant was

B as same color as A

image

Is it what u did too ?

No, A and B are not same I have to look what A is using and I will do same with B 😁

@prathamsoni11
Copy link
Contributor

@AshAman999 changed card colour as you said

@AshAman999
Copy link
Member

I guess it looks good as of now, just double check if it looks consistent even on the light theme

and do create a PR

@prathamsoni11
Copy link
Contributor

@AshAman999 What about that shimmer effect and that finish widget?

Screenrecorder-2022-12-09-18-12-37-631.mp4

@AshAman999 also have a look to this.

@prathamsoni11
Copy link
Contributor

I guess it looks good as of now, just double check if it looks consistent even on the light theme

and do create a PR

ok I will drop a screenshot

@M123-dev
Copy link
Member

M123-dev commented Jan 2, 2023

Looks great, my only concern is the text size, we could make it smaller and more subtle, it's only a sub feature of the product page

@prathamsoni11
Copy link
Contributor

I guess it looks good as of now, just double check if it looks consistent even on the light theme

and do create a PR

@teolemon
Copy link
Member Author

As far as I see, this does not work.

Here's a screenshot from a similar thing in Google Maps
image

@teolemon
Copy link
Member Author

@g123k

@g123k
Copy link
Collaborator

g123k commented Jun 16, 2023

As I want to implement #3986, I have looked at PR #3549 and there is a ProductQuestionPage, which seems to be missing now.

Any idea why it was removed?

@teolemon
Copy link
Member Author

Unsure @prathamsoni11 @M123-dev ?

@monsieurtanuki
Copy link
Contributor

@g123k I think it was either not used or a complete duplicate of QuestionPage.

@g123k
Copy link
Collaborator

g123k commented Jun 17, 2023

Ok, so I will re-introduce it, or partially at least.
One thing I will also work on, is the fact that every time we scroll, the previous call from Robotoff is not saved:

Robotoff.webm

@teolemon
Copy link
Member Author

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

6 participants