Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Addition - 'Finish' button overlays with 'Add basic details' button #2956

Closed
AshAman999 opened this issue Sep 7, 2022 · 4 comments
Closed
Labels
🐛 bug Something isn't working Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@AshAman999
Copy link
Member

AshAman999 commented Sep 7, 2022

What

  • When I am adding a new product, there seems to be overlaid on the last part of the buttons
  • It's inhibiting my ability to edit the basic product details when I scanned a new product
  • Problem arises when I add more additional photos

Expected behavior

The finish button should be at the bottom irrespective of the no of additional photos added

Why

  • It's annoying to come back to just edit one field

Part of

Screenshot/Mockup/Before-After

image

Smartphone model

  • Device: iPhone XR
  • OS: iOS 16 (beta)
  • App Version: 3.13.1 (Test Flight)

Additional context

@AshAman999 AshAman999 added the 🐛 bug Something isn't working label Sep 7, 2022
@AshAman999 AshAman999 added the Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. label Sep 7, 2022
@teolemon teolemon changed the title Finish button overlays with add basic details button in product addition Product Addition - 'Finish' button overlays with 'Add basic details' button Sep 7, 2022
@monsieurtanuki
Copy link
Contributor

cf. #2944: we would be better off with a FloatingActionButton.

@M123-dev
Copy link
Member

M123-dev commented Sep 7, 2022

Dublicate #2944

@M123-dev M123-dev closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 7, 2022
@AshAman999
Copy link
Member Author

I don't think so that it's duplicate, #2944 is about the snack bar blocking the view, but this issues was more of a layout overlay problem not of snack bar

@monsieurtanuki
Copy link
Contributor

@AshAman999 You may be right but my FloatingActionButton solution would solve both.
Feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Development

No branches or pull requests

3 participants