System Control request and response are REST-awkward

[pizthewiz]

A couple of things stick out:

• A POST is used for a value fetch and for a value change
• Two resources, VOLUME and MUTED are wrapped by a single edge, so when requesting the volume, we also get the muted state
• The level property provides the value for a GET_VOLUME request

[jsli]

Thanks for your proposal.
We will fix it ASAP.

[pizthewiz]

Great! In that case let me make a more clear suggestion:

• An API edge for each resource
• GET to fetch the value and POST to change it
• Return 200 on a successful GET and 201 on a successful POST

The value sent and received could be in a common parameter (like value below), or it could be in something edge specific like volume and mute.

Set volume:

$ curl -X POST -H "Content-Type: application/json" -d '{"value": 0.75}' \
http://localhost:9431/system/control/volume

Get volume:

$ curl -X GET http://localhost:9431/system/control/volume
{"value":0.75}

Set muted state:

$ curl -X POST -H "Content-Type: application/json" -d '{"value": true}' \
http://localhost:9431/system/control/mute

Get muted state:

$ curl -X GET http://localhost:9431/system/control/mute
{"value":true}

[jsli]

Thanks for your great suggestion! I'll implement it in a few days.
BTW, sometimes my english is not good enough to get all your points, if anything I misunderstood, just let me know.

[pizthewiz]

No problem, I'm glad to help out.

By the way is flingd-coffee the Flint daemon running on the Matchstick? I thought it was just a software testing solution, but it seems very full-featured.

[jsli]

Thanks your help!
Yes, the Flint daemon is running on the Matchstick, and the Matchstick is the first reference product of Flint. And flingd-coffee is a full implementation of Flint, but not just a software test solution, and flingd-coffee will be more perfect with your guys' help.
Did I described clearly? I'm sorry about my poor english, if any confusion you have, let me know.

[pizthewiz]

No that makes perfect sense, so if we run into issues with flingd-coffee we should report them as it is also running on the Matchstick. Thanks!

[jsli]

yes, the Matchstick should integrate these useful patches.