Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global ID #34

Open
johnb30 opened this issue Mar 25, 2014 · 4 comments
Open

Global ID #34

johnb30 opened this issue Mar 25, 2014 · 4 comments

Comments

@johnb30
Copy link
Member

johnb30 commented Mar 25, 2014

Need to add in a global, unique ID for each event record.

@ahalterman
Copy link
Member

Do you want them to be sequential/meaningful or can we just do an MD5 hash?

@johnb30
Copy link
Member Author

johnb30 commented Mar 30, 2014

I thought about doing MD5 hashes for something like URL + date, but it might be more useful to have something sequential and meaningful. Easy answer is why not both?

@ahalterman
Copy link
Member

Or just hash the text. It's fast.
I'm fine with both (meaningful ID vs. definitely unique ID).

On a semi-related note, can we switch the date to YYYYMMDD rather than YYMMDD? It's closer to ISO and I think it's easier to read and it's much easier to convert into ISO later. I'm afraid that would break some things but it's something to think about.

@johnb30
Copy link
Member Author

johnb30 commented Mar 31, 2014

I'm fine with hashing the text and putting in both sequential and fully unique ID. I'm also fine with the 8-digit date rather than the 6. I wonder if @philip-schrodt has any input on this? It should be just a matter of changing the format at https://github.com/openeventdata/phoenix_pipeline/blob/master/phox_pipeline.py#L27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants