Mdl4.5 core_external\external_api_test units failing because of mod_equella functions in externallib.php

[aneno-m-e]

Running core_external\external_api_test::test_all_external_info unit test in isolation results in the following output:

There were 2 errors:

1) core_external\external_api_test::test_all_external_info with data set "equella_find_all_usage" (stdClass Object (...))
Unexpected debugging() call detected.
Debugging: Invalid $required parameter value: '' .
                It must be either VALUE_DEFAULT, VALUE_REQUIRED, or VALUE_OPTIONAL

2) core_external\external_api_test::test_all_external_info with data set "equella_find_usage_for_item" (stdClass Object (...))
Unexpected debugging() call detected.
Debugging: Invalid $required parameter value: '' .
                It must be either VALUE_DEFAULT, VALUE_REQUIRED, or VALUE_OPTIONAL

The issue seems to come from L137 and L165 of the externallib.php file.

Running:

• mod_equella: version 1.3.1
• Moodle Version: 4.5

[usqfowlerj]

The solution I've been using can be found in this branch.

[edalex-ian]

Thanks for raising this issue @aneno-m-e . @usqfowlerj would you have any interesting in converting that branch into a PR?