Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equella config using $CFG #40

Open
danmarsden opened this issue Sep 14, 2016 · 3 comments
Open

equella config using $CFG #40

danmarsden opened this issue Sep 14, 2016 · 3 comments
Assignees
Labels
keep alive Issues to keep around until resolved

Comments

@danmarsden
Copy link
Contributor

should really be using config_plugins table instead of main $CFG var.

eg:
$settings->add(new admin_setting_configtext('equella_url', ecs('url.title'), ecs('url.desc'), ''));
should be
$settings->add(new admin_setting_configtext('equella/equella_url', ecs('url.title'), ecs('url.desc'), ''));

@cathfitz cathfitz added this to the 1.1.0 milestone Feb 28, 2020
@cathfitz cathfitz assigned cathfitz and mrblippy and unassigned cathfitz Feb 28, 2020
@cathfitz cathfitz modified the milestones: 1.1.0, 1.2 Mar 25, 2020
@stale
Copy link

stale bot commented Jul 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues with no recent activity, which will be automatically closed but kept for future reference. label Jul 29, 2020
@danmarsden
Copy link
Contributor Author

looks like this is still an issue.

@stale stale bot removed the stale Issues with no recent activity, which will be automatically closed but kept for future reference. label Jul 29, 2020
@edalex-ian edalex-ian added the keep alive Issues to keep around until resolved label Jul 29, 2020
@edalex-ian
Copy link
Member

Thanks @danmarsden , we'll keep it pinned then. ;)

@cathfitz cathfitz removed this from the 1.2 milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep alive Issues to keep around until resolved
Projects
None yet
Development

No branches or pull requests

4 participants