-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test failure] TC_LEARNER_7: Can't create an account #318
Comments
@kdmccormick I definitely encountered the same issue on the demo / test server. I didn't report it yet as I was giving time to @regisb in order to fix potential issues with the MFEs that were made available earlier today by @arbrandes. Thanks for reporting it. |
Still unable to create an account after Dean officially announced testing earlier today. |
In my notes I said:
Unfortunately, this turned out to be a separate issue, caused by the pyjkest->pyjwt upgrade which merged after the Quince cut. (it's now fixed in Tutor nightly). So, we currently have no leads on what might be causing this. Is there anyone with an account already created that can confirm whether login works? Or are we all locked out right now? |
@kdmccormick: I logged in using the default credentials listed here, but of course I didn't create the account. |
This is definitely a critical issue, but please don't let it block your testing. You can login with existing admin or student credentials:
|
I've been looking into this and I am sitll debuggin it, I will report here as soon as I find something or open a PR..etc |
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
Regarding the account creation issue, I opened a PR upstream to fix it openedx/frontend-app-authn#1099 I am sure it will resolve it but I am not sure if it’s the best solution… I think at least we know now, where is it coming from; The Country Field |
I tested this on my local environment, which worked like a charm! Now I'm wondering what changed that now is failing. @ghassanmas: do you have a clue on what could have happened? 🤔 |
@mariajgrimaldi I didn't quite get that, could you elobrate please? What is failing exactly? |
@ghassanmas: the registration process |
It still fails on edly (the main sandbox) because still my PR, needs to be merged and backported. Or do you mean it stills fails for you locally? |
@ghassanmas: I tested locally and it's working. I meant why it's failing in quince. Sorry if I wasn't clear😅 |
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
I deployed Ghassan's fix on the demo server, so users should be able to sign up. Again, this is a temporary fix and we will need to merge (and backport) Ghassan's PR before the Quince release. |
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
This was fixed by the PR linked above. |
@mariajgrimaldi Verified. Thanks. |
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
Release
Quince
Expected behavior
"Register" lets me create an account
Actual behavior
Steps to reproduce
Additional information
Notes:
I am noticing the same behavior on a laptop installation of Tutor Nightly, both in local and dev modes.In that same laptop installation, I'm getting this JWT issue when trying to log in, which Toby has a suggested fix for: https://discuss.openedx.org/t/tutor-nightly-login-error-rsa-key-must-include-all-parameters-if-any-are-present-besides-d/11479The text was updated successfully, but these errors were encountered: