Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chunked data in EMSI client for xblock-skills job #182

Merged

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Sep 11, 2023

Jira Ticket: ENT-7588

Description:
LightCast API was throwing errors when processing larger data sizes, handled it by adjusting data chunking to a maximum size of 50,000 bytes, aligning with LightCast's supported max data size limit.

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • make upgrade && make requirements have been run to regenerate requirements
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
  • Version bumped
  • Changelog record added

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in course-discovery to upgrade dependencies (including taxonomy-connector)
    • This must be done after the version is visible in PyPi as make upgrade in course-discovery will look for the latest version in PyPi.

@mahamakifdar19 mahamakifdar19 force-pushed the maham-akif/ENT-7588-refresh-xblock-skills-errors branch 2 times, most recently from 75dd280 to 6b7301a Compare September 12, 2023 08:18
@mahamakifdar19 mahamakifdar19 force-pushed the maham-akif/ENT-7588-refresh-xblock-skills-errors branch from 6b7301a to 7675deb Compare September 12, 2023 08:19
Copy link
Contributor

@saleem-latif saleem-latif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍🏼

@mahamakifdar19 mahamakifdar19 merged commit 50d77ac into master Sep 13, 2023
9 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham-akif/ENT-7588-refresh-xblock-skills-errors branch September 13, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants