fix: allow merging non-translations pull requests #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `validate-translation-files.yml` workflow is now required, but it runs only on PRs in which `translations/**` have been edited. This causes the non-translation pull requests to be blocked from merging because the `validate-translation-files.yml` won't run depite being required.
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
|
@shadinaif would you mind taking a look? |
OmarIthawi
changed the title
|
Sounds reasonable, thank you @OmarIthawi ! |
shadinaif
approved these changes
Sep 12, 2023
|
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validate-translation-files.ymlworkflow is now required, but it runs only on PRs in whichtranslations/**have been edited.This causes the non-translation pull requests to be blocked from merging because the
validate-translation-files.ymlwon't run despite being required.Related issues:
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.